Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You down with plt (yeah you know me) [Issue 97] #119

Merged
merged 23 commits into from
May 9, 2019
Merged

You down with plt (yeah you know me) [Issue 97] #119

merged 23 commits into from
May 9, 2019

Conversation

joshcombes
Copy link
Contributor

@joshcombes joshcombes commented May 7, 2019 •
edited
Loading

This is the start of the plotting overhaul. First step is to replace the functionality, second is to remove old functions.

This PR includes:

  • two ways to visualize a quantum state in the Pauli basis
  • Plotting of a Pauli Transfer Matrix
  • Plotting a real matrix using a Hinton diagram (similar but different to the above)
  • the addition of the computational basis as a predefined basis object

The only remaining thing related to this is to Check / fix plotting in state and process tomography notebooks after operator estimation is fixed which is covered by issue #94

@joshcombes joshcombes requested a review from a team as a code owner May 7, 2019 02:15
@joshcombes joshcombes changed the title You down with plt (yeah you know me) You down with plt (yeah you know me) [Issue 97] May 7, 2019
@joshcombes joshcombes mentioned this pull request May 7, 2019
Closed
4 tasks
kylegulshen
kylegulshen approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@kylegulshen kylegulshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Lmk the advantage of the real_hinton plot over the complex valued hinton plot.

examples/state_and_process_plots.ipynb Show resolved Hide resolved
kylegulshen and others added 5 commits May 8, 2019 12:56
@kylegulshen
Strip notebook, whitespace edits.
dad3abd
doc string catch Pauli -> computational
6695510
Merge branch 'You-down-with-PLT-(Yeah-you-know-me)-' of github.com:ri…
1026309 
…getti/forest-benchmarking into You-down-with-PLT-(Yeah-you-know-me)-
positive values = white
f4c9791 
neg values = black
radius = mag
this address kyle's point
fix plot titles
b0e574c
@joshcombes joshcombes merged commit 6dcfa52 into master May 9, 2019
@joshcombes joshcombes deleted the You-down-with-PLT-(Yeah-you-know-me)- branch May 9, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegulshen kylegulshen kylegulshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcombes @kylegulshen