Added TCP LinkLayer to socktap #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riebl
reviewed
Jun 9, 2023
| std::string tcp_ip; | ||
| unsigned short tcp_port, tcp_ip_len; | ||
|
|
||
| if (vm.count("tcp-connect")) { |
There was a problem hiding this comment.
I am not sure if vm.count is necessary: An empty vector of string would be just fine.
tools/socktap/tcp_link.hpp
Outdated
|
|
||
| private: | ||
| std::list<TcpSocket*> sockets_; | ||
| std::map<boost::asio::ip::tcp::endpoint, boost::asio::ip::tcp::acceptor*> acceptors_; |
There was a problem hiding this comment.
Same here, storing acceptor objects instead of pointers simplifies memory management.
|
Nice! Let me give it a final try, I will merge it then. |
|
I've just encountered some issues with it today. |
|
@riebl I have resolved the issues. |
riebl
requested changes
Aug 5, 2023
|
Thanks a lot for your patience while contributing your TCP link layer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added TCP to socktap.
To accept incoming connections, use
--tcp-accept 127.0.0.1:12345.To connect to another service, use
--tcp-connect 127.0.0.1:12345.