Skip to content

fix: some attachments have invalid filenames, and duplicated attachment names overwrite eachother #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caesay
Copy link

@caesay caesay commented Apr 2, 2025

Closes #2

Per title. There were two bugs here:

  • When attachments have invalid filenames they can not be written to disk and this stops the whole process
  • When attachments from different emails have the same filename, they get overwritten in the output folder.
    • Now we check if the filename already exists, and if it does we write it to a new file with _1, _2, etc appended to the filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: ENOENT: no such file or directory
1 participant