Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Ship page style tweaks #73

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

alistair3149
Copy link
Contributor

  • Declutter hardpoint table: use darker border, fill empty margin, minor typography tweaks
  • Add hover state to hardpoint table
  • Use gray instead of primary color for stat title since it can be confused with links
  • Slightly decrease the font size of stat title and slightly increase the size for the value
  • Slightly increase the font size of the ship name
  • Use "Description" instead of "CIG says" as heading, syncing with other pages

When this is finalized I will apply the relevant tweaks to other page types.

localhost_4200_ships_aegs_avenger_stalker (1)
localhost_4200_ships_aegs_avenger_stalker (2)

@richardthombs
Copy link
Owner

I am having difficulty applying your PRs because they also include all of the other changes you have made.

@alistair3149
Copy link
Contributor Author

alistair3149 commented Dec 30, 2020

Hmm that's weird. I didn't include changes from the other PRs in the branch as you can see from the commit on my repo. Does rebasing work?

EDIT: Oh I see. #67 was reverted and it was in master so all my branches was targeting the master that included it. The PR should be mergable if either #67 is merged or merge any of the current PRs since they all included #67

EDIT: I opened #74 that is identical to #67. Merging that to master will restore the branch back to the previous master or you can do a FF if you prefer

@alistair3149 alistair3149 marked this pull request as draft January 23, 2021 07:12
@alistair3149
Copy link
Contributor Author

Convert to draft because of rebase

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants