Skip to content

Commit

Permalink
chore: update comments related to KMS
Browse files Browse the repository at this point in the history
  • Loading branch information
ricardolsmendes committed Jun 1, 2024
1 parent 9dac78a commit ce5e67d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions infrastructure/modules/core/kms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
# https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingEncryption.html for further
# details.
# =======================================================================================
# THE KMS KEY IS DISABLED BY DEFAULT TO AVOID EXTRA COSTS IN THE BLUEPRINT VALIDATION
# THE KMS KEY IS NOT CREATED BY DEFAULT TO AVOID EXTRA COSTS IN THE BLUEPRINT VALIDATION
# ACCOUNTS. DELETE THE LINES DELIMITED BY `# =...=` AND UNCOMMENT THE FOLLOWING RESOURCES
# TO CREATE/ENABLE THEM.
# TO CREATE/ENABLE IT.
# =======================================================================================
# resource "aws_kms_key" "s3" {
# description = "This key protects S3 objects tackled by the AWS Glue CI/CD Blueprint"
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/modules/core/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ output "data_bucket_id" {
}

# =======================================================================================
# KMS KEY ARE DISABLED BY DEFAULT. PLEASE REFER TO `kms.tf` FOR DETAILS.
# THE KMS KEY IS NOT CREATED BY DEFAULT. PLEASE REFER TO `kms.tf` FOR DETAILS.
# =======================================================================================
# output "s3_encryption_key_arn" {
# value = aws_kms_key.s3.arn
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/modules/core/s3.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ resource "aws_s3_bucket" "data" {
}

# =======================================================================================
# KMS KEY ARE DISABLED BY DEFAULT. PLEASE REFER TO `kms.tf` FOR DETAILS.
# THE KMS KEY IS NOT CREATED BY DEFAULT. PLEASE REFER TO `kms.tf` FOR DETAILS.
# =======================================================================================
# resource "aws_s3_bucket_server_side_encryption_configuration" "data" {
# bucket = aws_s3_bucket.data.id
Expand Down

0 comments on commit ce5e67d

Please sign in to comment.