NO-JIRA: remove acm-version check for acm-alerting ui feature #677
Conversation
PeterYurkovich
requested review from
jan--f and
danielmellado
and removed request for
a team
PeterYurkovich
changed the title
|
@PeterYurkovich: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR looks to remove the ACM version check and remove the dependency of this repository on github.com/stolostron/multiclusterhub-operator. This change allows for a user to create a UIPlugin, with type monitoring and the feature acm enabled before having ACM installed.
While this could lead to some wasted resources as the monitoring-console-plugin deployment is created without showing any UI changes, it makes the installation process of the plugin and ACM reversible and more seamless. When ACM is then installed, the Observe > Alerting section will already be available for use.
Further discussion in slack.