Add test support of bootupd EUFI entry insertion #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-tmt |
|
/test-os-variants |
rvykydal
approved these changes
Jul 22, 2024
With this the test VM can run with UEFI support.
In fast path when reading ./discinfo we returned Fedora but when reading os-release it is returned fedora. This capital "F" makes our conditions to fail.
jkonecny12
force-pushed
the
add-bootc-leavebootorder-test
branch
from
0dba74e
to
a773def
Compare
|
UPDATED:
The bootc test won't work in UEFI mode for some reason and honestly maybe that is expected because UEFI entry is not created by bootupd. So to be able to cover all the cases let's have another test for uefi which will be used only on Fedora where this functionality works. |
|
/test-tmt |
|
/test-os-variants |
The rpm-ostree-container installations will by default install an UEFI entry which did not happened before. However, if leavebootorder is set it shouldn't happen. On RHEL-9 and RHEL-10 the leavebootorder will be ignored because it's not yet implemented, however, the final behavior is the same so let's leave it enabled also on these platforms.
This test works similar to `rpm-ostree-container-bootc` test but it will also check for UEFI entry and boot the system in UEFI mode. It might be merged together with bootc test but RHEL-9 and RHEL-10 are failing there currently.
jkonecny12
force-pushed
the
add-bootc-leavebootorder-test
branch
from
a773def
to
e7591e0
Compare
|
/test-tmt |
|
/test-os-variants |
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance existing test
rpm-ostree-container-bootcto check for UEFI entry insertion on the first disk.Add a new test working similar to other container tests but with
bootloader --leavebootorderwhich will disable UEFI entry insertion.To be able to do this add support to run VM in UEFI mode. And fix one bug during the path which caused troubles here.
The bootc test will be enabled only for Fedora until rhinstaller/anaconda#5760 and rhinstaller/anaconda#5761 are merged. The leavebootorder test should work all the time because UEFI entry just won't be inserted anyway on RHEL 9 and 10