Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data: profile: extend workstation profile to hide pages for Web UI #6047

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

data: profile: extend workstation profile to hide pages for Web UI #6047

wants to merge 3 commits into from

Conversation

KKoukiou
Copy link
Contributor

This was previously handled within the Web UI codebase. Now we hide pages specified by the hidden_pages configuration option.

Related to: rhinstaller/anaconda-webui#551
Related to: https://issues.redhat.com/browse/INSTALLER-4085

@github-actions github-actions bot added the f42 Fedora 42 label Dec 13, 2024
jkonecny12
jkonecny12 requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to extend anaconda.conf with the defaults of the field. Also please add comments.

I also wonder if it shouldn't be hidden_webui_pages to be crystal clear.

@KKoukiou
Copy link
Contributor Author

You also need to extend anaconda.conf with the defaults of the field. Also please add comments.

I also wonder if it shouldn't be hidden_webui_pages to be crystal clear.

I am in for the clarification.

@KKoukiou
Copy link
Contributor Author

You also need to extend anaconda.conf with the defaults of the field. Also please add comments.

I also wonder if it shouldn't be hidden_webui_pages to be crystal clear.

I am in for the clarified version.

@KKoukiou KKoukiou force-pushed the hidden_screens_webui branch from 1c56415 to 3d7771b Compare December 16, 2024 12:44
@KKoukiou KKoukiou force-pushed the hidden_screens_webui branch from 3d7771b to 9683d73 Compare December 16, 2024 12:49
M4rtinK
M4rtinK approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

Longer term we might need something more granular and/or dynamic, but this should work fine for now. :)

@KKoukiou
Copy link
Contributor Author

/kickstart-tests --waive webui config

@KKoukiou KKoukiou requested a review from jkonecny12 December 17, 2024 06:47
KKoukiou
KKoukiou commented Dec 17, 2024
View reviewed changes
Copy link
Contributor Author

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was re-thinking about this. I dont think screen is the correct item to specify hiding. I think we should allow hiding components .
The issue is that the screens might incorportate multiple configurations, aka language together with keyboard and timezone.

Maybe we want to keep the language selection for Workstation, but we dont want the timezone.

I believe we need some more fine grained approach here.

What do you think? @jkonecny12 @M4rtinK

@jkonecny12
Copy link
Member

Sounds like a good approach. We just need to make it easy to list possible options. It could be comments in the configuration file?

@KKoukiou
Copy link
Contributor Author

Sounds like a good approach. We just need to make it easy to list possible options. It could be comments in the configuration file?

Sorry now that I am rethinking this, this would complicate things quite a lot code wise. So I suggest to ignore my comment, start by disabling wizard page level components, and and if in the future the design forces us to be more specific, I will re-think it.

KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Dec 23, 2024
@KKoukiou
Parse new 'hidden_screen' configuration file options
4cff6c5 
Previously we would be using the ISO variant (Boos, Live) from Anaconda configuration
file and we would conditionalize the page visibility in the Web UI code
according to that.
With this commit, the pages can be hidden per-new option of the
configuration file [1].

[1] rhinstaller/anaconda#6047
@KKoukiou KKoukiou force-pushed the hidden_screens_webui branch from 9683d73 to a39a497 Compare January 2, 2025 14:05
dependabot bot and others added 3 commits January 2, 2025 15:12
@dependabot @KKoukiou
infra: bump the pylint-and-astroid group in /dockerfile with 2 updates
be9c9e9 
Bumps the pylint-and-astroid group in /dockerfile with 2 updates: [pylint](https://github.com/pylint-dev/pylint) and [astroid](https://github.com/pylint-dev/astroid).


Updates `pylint` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v3.3.2...v3.3.3)

Updates `astroid` from 3.3.6 to 3.3.8
- [Release notes](https://github.com/pylint-dev/astroid/releases)
- [Changelog](https://github.com/pylint-dev/astroid/blob/main/ChangeLog)
- [Commits](pylint-dev/astroid@v3.3.6...v3.3.8)

---
updated-dependencies:
- dependency-name: pylint
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: pylint-and-astroid
- dependency-name: astroid
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: pylint-and-astroid
...

Signed-off-by: dependabot[bot] <[email protected]>
@KKoukiou
data: profile: extend workstation profile to hide pages for Web UI
ced57d3 
This was previously handled within the Web UI codebase. Now we hide
pages specified by the `hidden_pages` configuration option.
@KKoukiou
docs: add release note for the hidden-webui-pages configuration option
a48496d
@KKoukiou KKoukiou force-pushed the hidden_screens_webui branch from a39a497 to a48496d Compare January 2, 2025 14:13
@KKoukiou KKoukiou deployed to gh-cockpituous January 2, 2025 14:13 — with GitHub Actions Active
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Jan 2, 2025
@KKoukiou
Parse new 'hidden_screen' configuration file options
23e934e 
Previously we would be using the ISO variant (Boos, Live) from Anaconda configuration
file and we would conditionalize the page visibility in the Web UI code
according to that.
With this commit, the pages can be hidden per-new option of the
configuration file [1].

[1] rhinstaller/anaconda#6047
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Jan 2, 2025
@KKoukiou
Parse new 'hidden_screen' configuration file options
5b232b0 
Previously we would be using the ISO variant (Boot, Live) from Anaconda configuration
file and we would conditionalize the page visibility in the Web UI code
according to that.
With this commit, the pages can be hidden per-new option of the
configuration file [1].

[1] rhinstaller/anaconda#6047
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Jan 3, 2025
@KKoukiou
Parse new 'hidden_screen' configuration file options
5747d7a 
Previously we would be using the ISO variant (Boot, Live) from Anaconda configuration
file and we would conditionalize the page visibility in the Web UI code
according to that.
With this commit, the pages can be hidden per-new option of the
configuration file [1].

[1] rhinstaller/anaconda#6047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@jkonecny12 jkonecny12 Awaiting requested review from jkonecny12

Assignees
No one assigned
Labels
f42 Fedora 42
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKoukiou @jkonecny12 @M4rtinK