Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking whether a disk can be cleared during autopart #5943

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix checking whether a disk can be cleared during autopart #5943

merged 1 commit into from
Oct 17, 2024

Conversation

vojtechtrefny
Copy link
Contributor

One more issue related to the device ID change. This does not happen with "normal" disks because we use name as device ID for them so this is triggered on a system with a BIOS RAID array.

Resolves: rhbz#2317287

@github-actions github-actions bot added the f41 label Oct 16, 2024
@vojtechtrefny
Copy link
Contributor Author

Note this is a Fedora 41 blocker. If you want to test the fix, updates image is available here.

@vojtechtrefny
Copy link
Contributor Author

/kickstart-tests --testtype smoke

@vojtechtrefny
Copy link
Contributor Author

/kickstart-tests --testtype storage

@KKoukiou
Copy link
Contributor

The test failures are unrelated.

 INFO:libpermian.plugins.kickstart_test(Thread-5):[runner] network-static-2-httpks                                 | FAILED     | Validation failed with return code 1
INFO:libpermian.plugins.kickstart_test(Thread-5):[runner] bond2-httpks                                            | FAILED     | Validation failed with return code 1

KKoukiou
KKoukiou reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@KKoukiou KKoukiou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo in the commit message (checkign) and add a Cherry-picked from master commit line, to make it clear it's a backport ;) thanks for fixing this.

@vojtechtrefny
Fix checking whether a disk can be cleared during autopart
a29d100 
One more issue related to the device ID change. This does not
happen with "normal" disks because we use name as device ID for
them so this is triggered on a system with a BIOS RAID array.

Cherry-picked from master a3d56af

Resolves: rhbz#2317287
@vojtechtrefny
Copy link
Contributor Author

Please fix the typo in the commit message (checkign) and add a Cherry-picked from master commit line, to make it clear it's a backport ;) thanks for fixing this.

Fixed.

@KKoukiou KKoukiou changed the title Fix checkign whether a disk can be cleared during autopart Fix checking whether a disk can be cleared during autopart Oct 17, 2024
@KKoukiou
Copy link
Contributor

/kickstart-tests --waive ran already

@KKoukiou KKoukiou merged commit f63b69a into rhinstaller:fedora-41 Oct 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

Assignees
No one assigned
Labels
f41
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtechtrefny @KKoukiou