Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journal redirect on systems without journal #5935

Conversation

jkonecny12
Copy link
Member

We redirect all the error messages from stderr to journal in the main Anaconda process. This is mainly covering errors and warnings from GTK UI.

However, this code returns FileNotFound on systems which don't have journal enabled.

To fix this move this code under our existing logic for logging to journal which is enabled only on HW installations.

We redirect all the error messages from stderr to journal in the main
Anaconda process. This is mainly covering errors and warnings from
GTK UI.

However, this code returns FileNotFound on systems which don't have
journal enabled.

To fix this move this code under our existing logic for logging to
journal which is enabled only on HW installations.
@jkonecny12 jkonecny12 added the f42 Fedora 42 label Oct 14, 2024
@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get on which kind of system does this crash. And also how did it work on RHEL and breaking on Fedora tests.

@jkonecny12
Copy link
Member Author

This will fail in for example container. Container don't have any systemd running or journaling enabled. The reason why we are hitting it here is that in the OpenQA test they are running --no-virt livemedia-creator which will run Anaconda on the running system directly. That means if the system doesn't have journaling (container but maybe even other solution like mock?) it will fail because there is no journal log.

On RHEL, I guess the build is happening on VM directly (which was booted by standard way) or maybe without the --no-virt option. The same reason is probably true for standard ISO builds on FEDORA which to my understanding are working. This is about how OpenQA is building the Live ISO.

@KKoukiou KKoukiou requested a review from M4rtinK October 14, 2024 13:22
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! :)

@KKoukiou
Copy link
Contributor

Unit tests failures are known. Will be fixed by a blivet combined release - expected to happen today.

@KKoukiou KKoukiou merged commit e27e76c into rhinstaller:master Oct 14, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f42 Fedora 42
Development

Successfully merging this pull request may close these issues.

3 participants