-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix journal redirect on systems without journal #5935
Fix journal redirect on systems without journal #5935
Conversation
We redirect all the error messages from stderr to journal in the main Anaconda process. This is mainly covering errors and warnings from GTK UI. However, this code returns FileNotFound on systems which don't have journal enabled. To fix this move this code under our existing logic for logging to journal which is enabled only on HW installations.
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get on which kind of system does this crash. And also how did it work on RHEL and breaking on Fedora tests.
This will fail in for example container. Container don't have any systemd running or journaling enabled. The reason why we are hitting it here is that in the OpenQA test they are running On RHEL, I guess the build is happening on VM directly (which was booted by standard way) or maybe without the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks! :)
Unit tests failures are known. Will be fixed by a blivet combined release - expected to happen today. |
We redirect all the error messages from stderr to journal in the main Anaconda process. This is mainly covering errors and warnings from GTK UI.
However, this code returns FileNotFound on systems which don't have journal enabled.
To fix this move this code under our existing logic for logging to journal which is enabled only on HW installations.