Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rdp dns timeout #5930

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

KKoukiou
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Oct 10, 2024

Hello @KKoukiou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-10 16:34:25 UTC

@github-actions github-actions bot added the f42 Fedora 42 label Oct 10, 2024
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. :)

@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

Let's have it the last printed line so it's visible to users.
After starting RDP server we are showing connection information to user
so they know where to connect (IP and hostname). However, hostname
information is obtained from the DNS server which might take a while to
get these information.

To avoid blocking main thread move this hostname print to a separate
thread.
This method will print message for user, send ipmi message and kill
Anaconda.
Start checking return codes of the GRD calls.
Add information about possible raised exception.
@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member

The Web UI tests are expected to fail. Merging.

@jkonecny12 jkonecny12 merged commit b0dbdcb into rhinstaller:master Oct 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f42 Fedora 42
Development

Successfully merging this pull request may close these issues.

4 participants