-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rdp dns timeout #5930
Merged
jkonecny12
merged 6 commits into
rhinstaller:master
from
KKoukiou:master-fix-rdp-dns-timeout
Oct 10, 2024
Merged
Fix rdp dns timeout #5930
jkonecny12
merged 6 commits into
rhinstaller:master
from
KKoukiou:master-fix-rdp-dns-timeout
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
temporarily deployed
to
gh-cockpituous
October 10, 2024 15:25
— with
GitHub Actions
Inactive
M4rtinK
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. :)
KKoukiou
force-pushed
the
master-fix-rdp-dns-timeout
branch
from
October 10, 2024 15:55
90c9c30
to
fa343ed
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
October 10, 2024 15:55
— with
GitHub Actions
Inactive
/kickstart-test --testtype smoke |
Let's have it the last printed line so it's visible to users.
After starting RDP server we are showing connection information to user so they know where to connect (IP and hostname). However, hostname information is obtained from the DNS server which might take a while to get these information. To avoid blocking main thread move this hostname print to a separate thread.
This method will print message for user, send ipmi message and kill Anaconda.
Start checking return codes of the GRD calls.
Add information about possible raised exception.
jkonecny12
force-pushed
the
master-fix-rdp-dns-timeout
branch
from
October 10, 2024 16:34
fa343ed
to
715259a
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
October 10, 2024 16:34
— with
GitHub Actions
Inactive
/kickstart-test --testtype smoke |
The Web UI tests are expected to fail. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating PR from @jkonecny12 branch: https://github.com/jkonecny12/anaconda/tree/master-fix-rdp-dns-timeout