Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: enable NM autoconnections only if inst.ks and ip= is not used #5840

Draft
wants to merge 1 commit into
base: rhel-10
Choose a base branch
from
Draft

network: enable NM autoconnections only if inst.ks and ip= is not used #5840

wants to merge 1 commit into from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Aug 20, 2024 •
edited
Loading

Applies rhel-specific patch 49d345b to rhel-10

TODO:

  • Add a test (kickstart test?)
  • Try to figure out generic upstream solution / patch - would require detection of rhel (on systemd units level)

@rvykydal rvykydal added port to Fedora blocked Don't merge this pull request! and removed blocked Don't merge this pull request! labels Aug 20, 2024
M4rtinK
M4rtinK approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :) For the detection, I guess os-release parsing could work, but wonder if it would be robust enough. :)

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
port to Fedora rhel-10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @M4rtinK