Fix download of stage2 image from .treeinfo #5773
Open
+185
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype coverage |
1 similar comment
|
/kickstart-test --testtype coverage |
rvykydal
approved these changes
Jul 18, 2024
jcpunk
reviewed
Jul 24, 2024
dracut/anaconda-lib.sh
Outdated
| @@ -108,6 +112,10 @@ anaconda_net_root() { | |||
| local repo="$1" | |||
| info "anaconda: fetching stage2 from $repo" | |||
|
|
|||
| # Remove last `/` from repo to enable cunstructs like ...os/../BaseOS/image/install.img | |||
|
This PR is stale because it has been open 60 days with no activity. |
With commit 0785531 the `get_config` function in anaconda-lib.sh was broken because missing quotes removed leading and trailing whitespace characters automatically but after the fix in commit mentioned above this side effect was fixed which lead in broken code. In other words the key were never matched because of trailing whitespace. Issue raised by this is not being able to read .treeinfo and .buildstamp files in Dracut. Example of such situation is broken boot when stage2 image is stored under special path mentioned in .treeinfo file. Related: RHEL-48821
jkonecny12
force-pushed
the
master-fix-updir-unified-iso
branch
from
89fd44c to
0a2664e
Compare
|
Hello @jkonecny12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2025-01-20 16:28:49 UTC |
In Dracut the URL concatenation from .treeinfo could also point you to directory above by `..`. However, if the `inst.repo=` argument was set with trailing `/` it will create URL which is not supported by curl. Supported: `os/../BaseOS/` Unsupported by curl: `os//../BaseOS/` Remove the trailing `/` to avoid this issue. Resolves: RHEL-48821
jkonecny12
force-pushed
the
master-fix-updir-unified-iso
branch
from
0a2664e to
7a05f00
Compare
This commit will also add code to enable testing of the Dracut shell scripts. Related: RHEL-48821
Dracut testing should be more versatile with this approach. This is more an extension for future testing.
jkonecny12
force-pushed
the
master-fix-updir-unified-iso
branch
from
7a05f00 to
63b081c
Compare
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix to enable downloading stage2 image from a non default place with .treeinfo file. If .treeinfo has a path to the stage2 image it will be used as the first variant, in case this will fail it will fallback to default paths.
This is fixing two parts:
//in the path.Missing: