Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liveinst: bubble more user env variables through anaconda to the webui #5397

Closed
wants to merge 1 commit into from

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Jan 8, 2024

In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs in an environment as close to getting run directly by the live user as possible.

In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs
in an environment as close to getting run directly by the live user as possible.
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Jan 8, 2024

Split out of #5058 to check the CI.

@github-actions github-actions bot added the f40 label Jan 8, 2024
readarray -t user_environment < <(pkexec --user "${INSTALLER_USER}" env XDG_RUNTIME_DIR="/run/user/${PKEXEC_UID}" systemctl --user show-environment)

for variable in "${user_environment[@]}"; do
export "$variable"

Check warning

Code scanning / shellcheck

This does not export 'variable'. Remove $/${} for that, or use ${var?} to quiet. Warning

This does not export 'variable'. Remove $/${} for that, or use ${var?} to quiet.
@@ -22,13 +22,18 @@
# unprivileged, restart running as root.
if [ "$(id -u)" -ne 0 ]; then
xhost +si:localuser:root
unset XAUTHORITY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, all these changes work also on non-WebUI Live media, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to test all, Web UI and others - moved the PR to Draft to clarify this is a work in progress.

It's more like fresh version of #5058 so that I can generate some images and test, as I can't do it locally.

@KKoukiou KKoukiou marked this pull request as draft January 8, 2024 10:05
@KKoukiou KKoukiou added f41 and removed f40 labels Feb 29, 2024
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 30, 2024
@KKoukiou
Copy link
Contributor Author

KKoukiou commented May 7, 2024

This is not tested and I dont have time for this right now.

@KKoukiou KKoukiou closed this May 7, 2024
@KKoukiou KKoukiou deleted the liveuser-liveinst branch May 7, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants