Disable LVM devices file when running image installs #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
This depends on storaged-project/blivet#1169 but strictly speaking isn't really blocked by it thanks to Python magic which allows setting non-existing attributes :-) |
KKoukiou
approved these changes
Nov 20, 2023
|
/kickstart-test --testtype smoke |
VladimirSlavik
approved these changes
Nov 23, 2023
|
So, what's wrong with these tests? |
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
No idea: |
vojtechtrefny
force-pushed
the
master_lvmdevices-flag
branch
from
96876c9
to
b6ae2e7
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
So rebasing to the latest master fixed the unit test and now packit is failing :-) |
|
@vojtechtrefny it fails with:
We no longer require anaconda-user-help so I guess it's some old version of the GUI pulled in here. Feel free to ignore till we resolve this. |
vojtechtrefny
force-pushed
the
master_lvmdevices-flag
branch
from
b6ae2e7
to
da09c0d
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
The new blivet flag allows us to control whether the LVM devices file will be populated with PVs or not and we don't want to write the file when running an image installation. Resolves: rhbz#2247872
vojtechtrefny
force-pushed
the
master_lvmdevices-flag
branch
from
da09c0d
to
ae2533c
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Feb 21, 2024
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Feb 21, 2024
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Feb 21, 2024
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Feb 22, 2024
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Feb 22, 2024
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
vojtechtrefny
added a commit
to vojtechtrefny/anaconda
that referenced
this pull request
Feb 28, 2024
Follow up for rhinstaller#5325 which disables the LVM devices file usage on blivet side but we also need to skip writing the file when writing the storage configuration post install. Resolves: rhbz#2247872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new blivet flag allows us to control whether the LVM devices file will be populated with PVs or not and we don't want to write the file when running an image installation.
Resolves: rhbz#2247872