Webui: Fix for adding report for JS bugs #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkankovsky
force-pushed
the
webui-js-error-notify-fix
branch
from
86d9d5d
to
3839b45
Compare
KKoukiou
reviewed
Oct 19, 2023
ui/webui/src/components/app.jsx
Outdated
| </WithDialogs> | ||
| </AddressContext.Provider> | ||
| </Page>) | ||
| : (<Page>{null}</Page>)} |
There was a problem hiding this comment.
This looks pretty weird. Please put the Page wrapper to have child the 'Critical Error' component. Then put this condition to the rest of the children.
adamkankovsky
force-pushed
the
webui-js-error-notify-fix
branch
from
3839b45
to
b7f6b87
Compare
KKoukiou
approved these changes
Oct 19, 2023
KKoukiou
reviewed
Oct 19, 2023
|
/kickstart-test --waive webui only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To display error reporting for JS bugs, the content that creates the error must be hidden, so the page cannot be displayed in the background.
Fix for PR: #5225 (comment)