Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: catch exceptions from the backend in all actions #5251

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

KKoukiou
Copy link
Contributor

For this let's move criticalError to the central store.

@KKoukiou
Copy link
Contributor Author

I advice whoever reviews this one to do it with ignoring whitespace changes; https://github.com/rhinstaller/anaconda/pull/5251/files?diff=unified&w=1

@KKoukiou KKoukiou marked this pull request as draft October 16, 2023 07:12
For this let's move criticalError to the central store.
@KKoukiou KKoukiou force-pushed the webui-catch-errors-in-actions branch from 6281d6a to ab00e3a Compare October 16, 2023 11:08
@KKoukiou KKoukiou marked this pull request as ready for review October 16, 2023 11:10
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@adamkankovsky adamkankovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything wrong. Looks good.

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui only

@KKoukiou KKoukiou merged commit b86184e into rhinstaller:master Oct 16, 2023
17 checks passed
@KKoukiou KKoukiou deleted the webui-catch-errors-in-actions branch October 16, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants