webui: check existence of payload image when running testing VM #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
reviewed
Oct 10, 2023
ui/webui/test/machine_install.py
Outdated
| payload_cached_name, http_payload_port = self._serve_payload() | ||
| payload_path = os.path.join(BOTS_DIR, "./images/fedora-rawhide-anaconda-payload") | ||
| if not os.path.exists(payload_path): | ||
| raise FileNotFoundError(f"Missing payload file {payload_path}. (Maybe try running 'make payload').") |
There was a problem hiding this comment.
Perfect - just I would be more assertive on the suggestion.
raise FileNotFoundError(f"Missing payload file {payload_path}; use 'make payload').")
Not strong opinion though.
KKoukiou
approved these changes
Oct 10, 2023
Resolves: INSTALLER-3628
rvykydal
force-pushed
the
webui-check-payload-image-file-existence
branch
from
7618f1f
to
08fee4c
Compare
KKoukiou
approved these changes
Oct 11, 2023
|
/kickstart-test --waive webui-only |
M4rtinK
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.