webui: storage step improvements #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --waive webui only |
rvykydal
reviewed
Oct 10, 2023
Previously we were just adding new devices, never removing, resulting in accumulated obsolete devices in the store.
This replaces the `isInProgress`and its purpose is that it will prevent the user from doing UI operations while operations are running in the background. A visible change is that the footer should be always displayed and only if the 'isFormDisabled' is set the footer buttons should get disabled.
To prevent flickering UI while the user is performing some action. Also keep re-scan button disabled till the re-scanning really finishes. We need to Promise chain on the onSuccess callback, previously we were re-enabling the Re-scan button once the Task ran, not when it completed.
… are not loaded Also only reset the previous disks variable if it's undefined, which means that the user clicked the re-scan button.
KKoukiou
force-pushed
the
webui-storage-improvements-tests-stability
branch
from
08e46df
to
24ee190
Compare
rvykydal
approved these changes
Oct 10, 2023
adamkankovsky
approved these changes
Oct 10, 2023
|
/kickstart-test --waive webui only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.