webui: Stop pinning cockpit package versions, support testing against a cockpit PR #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
force-pushed
the
stop-pinning-cockpit
branch
from
e08201c
to
0e88407
Compare
We need to test the real distro, not what it was like 3 months ago. This will pave the way for gating cockpit changes on anaconda's tests (https://issues.redhat.com/browse/COCKPIT-1062). But still keep pinning firefox from commit 546cacc. Add a bug reference. This reverts commit 72ef923.
martinpitt
force-pushed
the
stop-pinning-cockpit
branch
from
0e88407
to
249d2ac
Compare
Enumerating the RPMs in prepare-updates-img is error-prone and redundant: `build-rpms` already only downloads selected RPMs, and we already install all of anaconda's built RPMs anyway (all of them start with "anaconda-"). This will make the installation more robust when the set of RPMs becomes more dynamic.
The three downloaded RPMs are tiny, and even the dnf metadata download should not take that long. If your system is too slow to download a few MB in 5 minutes, then it's not going to be able to download the large VM images. This avoids stalling the test for half an hour if the download hangs, let it fail faster instead.
We want to run Anaconda's tests in Cockpit PRs to ensure that changes to the bridge or the storage page don't break anaconda (https://issues.redhat.com/browse/COCKPIT-1062). For that, we need to be able to run the tests against a Cockpit COPR build instead of its rawhide RPMs. Support this via a `cockpit-pr-N` test scenario.
We will soon move from blivet-gui to cockpit's Storage page. This still requires some work, but already install it so that we can start writing integration tests, and keep them working via running Anaconda's tests in cockpit PRs. https://issues.redhat.com/browse/COCKPIT-1065
|
With this out of the way (tests passed), let's add testing against a cockpit PR and some extra cleanups. |
martinpitt
changed the title
|
While the standard run now installs current cockpit from rawhide: the cockpit-pr-19453 run installs the COPR: Note that this run was just for demo purposes -- of course this scenario would run in a cockpit PR, not an anaconda one. |
|
@KKoukiou Ready for reviewing now. Thanks in advance! |
KKoukiou
approved these changes
Oct 9, 2023
|
/kickstart-test --waive webui only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to test the real distro, not what it was like 3 months ago. This will pave the way for gating cockpit changes on anaconda's tests (https://issues.redhat.com/browse/COCKPIT-1062), which is supported through a scenario now.
After this lands, I'll teach cockpit's CI to run anaconda's tests with the PR's cockpit code, to make sure cockpit changes don't break anaconda.