Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: set form validity also at the initial load of the mount point mapping #5228

Merged
merged 1 commit into from
Oct 10, 2023
Merged

webui: set form validity also at the initial load of the mount point mapping #5228

merged 1 commit into from
Oct 10, 2023

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Oct 4, 2023 •
edited
Loading

Resolves: rhbz#2242086

@jkonecny12
Copy link
Member

Please change the commit message to:

Resolves: rhbz#2242086

That is the convention. I know it's convention to RHEL branches but in general we should be consistent.

VladimirSlavik
VladimirSlavik approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui only

@KKoukiou KKoukiou merged commit 5581726 into rhinstaller:master Oct 10, 2023
17 checks passed
@KKoukiou KKoukiou deleted the bz-2242086 branch October 10, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvykydal rvykydal rvykydal approved these changes

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
f40 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KKoukiou @jkonecny12 @rvykydal @VladimirSlavik