Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: setup lint for style files #4941

Merged
merged 2 commits into from
Jul 21, 2023
Merged

webui: setup lint for style files #4941

merged 2 commits into from
Jul 21, 2023

Conversation

adamkankovsky
Copy link
Contributor

No description provided.

VladimirSlavik
VladimirSlavik approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, as a person who does not know this, LGTM except for cosmetics.

I won't comment on the individual rules enabled or disabled - I understand this as initial support and rule tweaking or code fixing will come later.

ui/webui/.stylelintrc.json Outdated Show resolved Hide resolved
ui/webui/build.js Show resolved Hide resolved
ui/webui/package.json Show resolved Hide resolved
@adamkankovsky adamkankovsky force-pushed the webui-lint-for-style-files branch 2 times, most recently from b21998e to adb6e6f Compare July 21, 2023 12:25
@KKoukiou
Copy link
Contributor

/kickstart-test --waive webui only

@KKoukiou KKoukiou merged commit 674f2c1 into rhinstaller:master Jul 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

@KKoukiou KKoukiou KKoukiou approved these changes

Assignees
No one assigned
Labels
f39 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkankovsky @KKoukiou @VladimirSlavik