webui: tests: make some more tests non-destructive #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was problematic if this existed prior to entering the custom partitioning step. Then partitioningData.requests is 'undefined'.
These tests partition the vda device. Just wipe the partitions in the test tearDown, to allow reuse of the same test VM in followup tests.
|
/kickstart-test --waive webui only |
jelly
reviewed
Jul 21, 2023
VladimirSlavik
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Thank you, I like the idea and hope it works out. In principle, if we eventually test "the same things" in the costly e2e tests, making the assumption this is fine... is fine?
I wonder if there is some way to ensure these tests run the same on clean start and after something else...
jelly
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.