Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix expected value for "has_key" with latest blivet #4928

Merged

Conversation

vojtechtrefny
Copy link
Contributor

LUKS.has_key was changed to always return boolean in the latest blivet (see storaged-project/blivet#1142) so we need to change expected value here.

Note: The blivet change is already merged, but because of the mass rebuild our daily builds copr repo is now behind
rawhide. This is now fixed (storaged-project/blivet@09d6099), so the tests will start failing after the next blivet nightly build.

Related: storaged-project/blivet#1142
Related: storaged-project/blivet#1144
Related: #4873

@github-actions github-actions bot added the f39 label Jul 19, 2023
@vojtechtrefny vojtechtrefny added blocked Don't merge this pull request! f39 and removed f39 blocked Don't merge this pull request! labels Jul 19, 2023
@vojtechtrefny vojtechtrefny marked this pull request as ready for review July 19, 2023 14:46
@vojtechtrefny
Copy link
Contributor Author

The latest build of blivet (3.8.0-99.20230719142909918937.3.8.devel.13.g409d9657 ) is now available in Copr. Unfortunately the CI container now fails, because running tests is part of the container creation and the tests fail, because this fix is missing. I am not sure what is the correct process for merging something without tests passing. @VladimirSlavik can you look at this please, thanks.

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@VladimirSlavik
Copy link
Contributor

@vojtechtrefny I understand - the container needs this for tests to pass, but it is not rebuilt for the tests here because you don't change the container, only tests.

So, to get the actual results, run this:

make -f Makefile.am anaconda-ci-build
make -f Makefile.am container-ci

If this works OK, then the tests effectively pass.

You probably don't want to keep the locally built container, so after you're done, you want also:

podman rmi quay.io/rhinstaller/anaconda-ci:master

@VladimirSlavik VladimirSlavik self-assigned this Jul 20, 2023
@vojtechtrefny
Copy link
Contributor Author

So, to get the actual results, run this:

make -f Makefile.am anaconda-ci-build
make -f Makefile.am container-ci

If this works OK, then the tests effectively pass.

Thanks, the test passed for me in the locally built container.

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

LUKS.has_key was changed to always return boolean in the latest
blivet (see storaged-project/blivet#1142)
so we need to change expected value here.
@VladimirSlavik
Copy link
Contributor

/kickstart-test --waive test only

@VladimirSlavik VladimirSlavik merged commit 8e4047a into rhinstaller:master Jul 21, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants