-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Fix expected value for "has_key" with latest blivet #4928
tests: Fix expected value for "has_key" with latest blivet #4928
Conversation
The latest build of blivet (3.8.0-99.20230719142909918937.3.8.devel.13.g409d9657 ) is now available in Copr. Unfortunately the CI container now fails, because running tests is part of the container creation and the tests fail, because this fix is missing. I am not sure what is the correct process for merging something without tests passing. @VladimirSlavik can you look at this please, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
@vojtechtrefny I understand - the container needs this for tests to pass, but it is not rebuilt for the tests here because you don't change the container, only tests. So, to get the actual results, run this:
If this works OK, then the tests effectively pass. You probably don't want to keep the locally built container, so after you're done, you want also:
|
Thanks, the test passed for me in the locally built container. |
/kickstart-test --testtype smoke |
b2c7949
to
58cacdb
Compare
LUKS.has_key was changed to always return boolean in the latest blivet (see storaged-project/blivet#1142) so we need to change expected value here.
58cacdb
to
c5a2f1b
Compare
/kickstart-test --waive test only |
LUKS.has_key was changed to always return boolean in the latest blivet (see storaged-project/blivet#1142) so we need to change expected value here.
Note: The blivet change is already merged, but because of the mass rebuild our daily builds copr repo is now behind
rawhide. This is now fixed (storaged-project/blivet@09d6099), so the tests will start failing after the next blivet nightly build.
Related: storaged-project/blivet#1142
Related: storaged-project/blivet#1144
Related: #4873