webui: simplify webui-desktop script #4919
Conversation
|
This fixes the crash but it seems that still the VM does not shutoff. |
KKoukiou
force-pushed
the
webui-desktop-simplify
branch
from
7f12739
to
0819217
Compare
| # start the bridge; this needs to run in the normal user session/namespace | ||
| coproc ${2:+ssh "$2"} cockpit-bridge | ||
| trap "kill $COPROC_PID; wait $COPROC_PID || true" EXIT INT QUIT PIPE | ||
| BROWSER="/usr/bin/firefox --kiosk" |
There was a problem hiding this comment.
So I'm using this variable on my Firefox theme PR: https://github.com/rhinstaller/anaconda/pull/4918/files#diff-4384704581bd02e11beb389b584be16b175b80679194ac91422ed2701d8bd3bdR139
I wonder - now that we started changing it maybe this script is a better place for the theme handling than the UI handling Python code where I put it in my PR ? What do you think ?
We might have to solve live/boot.iso detection somehow, but otherwise it should work.
There was a problem hiding this comment.
Yes it probably makes more sense that the theming gets applied here.
There was a problem hiding this comment.
OK, so I'll adjust #4918 accordingly. :)
KKoukiou
force-pushed
the
webui-desktop-simplify
branch
from
0819217
to
9e2b6ad
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKoukiou
force-pushed
the
webui-desktop-simplify
branch
from
9e2b6ad
to
25aecdf
Compare
There was a problem hiding this comment.
Thanks! LGTM (mostly), but it still seems to fail? Or is that unrelated?
ui/webui/webui-desktop
Outdated
| # start the bridge; this needs to run in the normal user session/namespace | ||
| coproc ${2:+ssh "$2"} cockpit-bridge | ||
| trap "kill $COPROC_PID; wait $COPROC_PID || true" EXIT INT QUIT PIPE | ||
| BROWSER="/usr/bin/firefox --kiosk" | ||
|
|
||
| # start ws and browser in a detached network namespace |
There was a problem hiding this comment.
This comment is obsolete and wrong now.
Stop using coproc, nesting bash and calling unshare. All these are needed for the namespace isolation which we don't need in anaconda.
KKoukiou
force-pushed
the
webui-desktop-simplify
branch
from
25aecdf
to
5727674
Compare
|
fedora-rawhide-boot@bots#4976 is passing now. |
|
/kickstart-test --waive webui only |
Stop using coproc, nesting bash and calling unshare. All these are needed for the namespace isolation which we don't need in anaconda.