Add possibility to run pylint-only test #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint was recently removed from the default test suite because it caused issues on python 3.12. To be able to verify if that issue was resolved and in general improve state of running just this test this change introduce a possibility to run just pylint test in container or without the container. Usually this should be solved by `make check TESTS=<pylint>`, unfortunately this is not possible for pylint for unknown reasons. The same situation works for unit tests but when pylint is used this way it not even try to start the tests. Seems to me like some automake magic fails here. Even automake substition doesn't work here. Seems that pylint test has to be in the TESTS variable hardcoded which can't happen if it is not part of the default runs. Anyhow, to resolve this issue a new script was introduced to set environment variables correctly to the pylint start so it's easy and consistent to start the pylint tests.
VladimirSlavik
approved these changes
Jul 14, 2023
vojtechtrefny
approved these changes
Jul 14, 2023
|
/kickstart-test --waive tests only |
|
The test failures are not related - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint was recently removed from the default test suite because it caused issues on python 3.12. To be able to verify if that issue was resolved and in general improve state of running just this test this change introduce a possibility to run just pylint test in container or without the container.
Usually this should be solved by
make check TESTS=<pylint>, unfortunately this is not possible for pylint for unknown reasons. The same situation works for unit tests but when pylint is used this way it not even try to start the tests. Seems to me like some automake magic fails here. Even automake substition doesn't work here. Seems that pylint test has to be in the TESTS variable hardcoded which can't happen if it is not part of the default runs.Anyhow, to resolve this issue a new script was introduced to set environment variables correctly to the pylint start so it's easy and consistent to start the pylint tests.