Check source type directly, not via DBus #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all payloads are available via DBus in RHEL 9 Anaconda, so use the payload instance directly when checking payload type in the Connect to Red Hat spokes. Also in some cases the payload type could be None instead of a string, so handle that as well. This should fix the issue with RHV, which uses the liveimg payload, which is not available via DBus on RHEL 9, leading to a crash. (cherry picked from commit d6ea3b3) Related: rhbz#1941578 Resolves: rhbz#1955311
M4rtinK
force-pushed
the
rhel-9-check_source_type_directly
branch
from
96cc57c
to
f1fc6d4
Compare
VladimirSlavik
approved these changes
Aug 17, 2021
poncovka
approved these changes
Aug 17, 2021
|
/kickstart-test --testtype smoke |
1 similar comment
|
/kickstart-test --testtype smoke |
M4rtinK
added
the
ready to merge
M4rtinK
added
port to Fedora
and removed
port to Fedora
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all payloads are available via DBus in RHEL 9 Anaconda,
so use the payload instance directly when checking payload type
in the Connect to Red Hat spokes. Also in some cases the payload
type could be None instead of a string, so handle that as well.
This should fix the issue with RHV, which uses the liveimg payload,
which is not available via DBus on RHEL 9, leading to a crash.
(cherry picked from commit d6ea3b3)
Related: rhbz#1941578
Resolves: rhbz#1955311