Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: crypt user password by default before passing it to backend #48

Merged
merged 1 commit into from
Nov 23, 2023
Merged

webui: crypt user password by default before passing it to backend #48

merged 1 commit into from
Nov 23, 2023

Conversation

rvykydal
Copy link
Contributor

NOTE: using the same method as the current Gtk GUI

This is the PR rhinstaller/anaconda#5321 migrated to the new repository.

@rvykydal rvykydal marked this pull request as ready for review November 20, 2023 11:59
@rvykydal rvykydal mentioned this pull request Nov 20, 2023
Closed
KKoukiou
KKoukiou requested changes Nov 20, 2023
View reviewed changes
src/components/users/Accounts.jsx Outdated Show resolved Hide resolved
KKoukiou
KKoukiou previously approved these changes Nov 21, 2023
View reviewed changes
@KKoukiou
Copy link
Contributor

@rvykydal weirdly this consistently breaks the Progress test:
https://cockpit-logs.us-east-1.linodeobjects.com/pull-48-20231123-070254-c2bc29f0-fedora-rawhide-boot/log.html#8-2

@KKoukiou KKoukiou dismissed their stale review November 23, 2023 07:59

Test failures on the full installation test

@rvykydal
Copy link
Contributor Author

@rvykydal weirdly this consistently breaks the Progress test: https://cockpit-logs.us-east-1.linodeobjects.com/pull-48-20231123-070254-c2bc29f0-fedora-rawhide-boot/log.html#8-2

oh yes, need to fix it:

Nov 23 07:31:32 ibm-p8-kvm-03-guest-02.virt.pnr.lab.eng.rdu2.redhat.com org.fedoraproject.Anaconda.Modules.Users[4162]:   File "/usr/lib64/python3.12/site-packages/pyanaconda/core/users.py", line 503, in set_user_password
Nov 23 07:31:32 ibm-p8-kvm-03-guest-02.virt.pnr.lab.eng.rdu2.redhat.com org.fedoraproject.Anaconda.Modules.Users[4162]:     raise OSError("Unable to set password for new user: status=%s" % proc.returncode)
Nov 23 07:31:32 ibm-p8-kvm-03-guest-02.virt.pnr.lab.eng.rdu2.redhat.com org.fedoraproject.Anaconda.Modules.Users[4162]: OSError: Unable to set password for new user: status=1

@rvykydal
webui: crypt user password by default before passing it to backend
743039c 
NOTE: using the same method as the current Gtk GUI
@rvykydal rvykydal merged commit 3305a96 into rhinstaller:main Nov 23, 2023
4 checks passed
adamkankovsky pushed a commit to adamkankovsky/anaconda-webui that referenced this pull request Nov 23, 2023
@rvykydal @adamkankovsky
Merge pull request rhinstaller#48 from rvykydal/users-encrypt-password
7bae548 
webui: crypt user password by default before passing it to backend
@rvykydal rvykydal mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @KKoukiou