-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENJDK-3591 merge back jlink #556
Open
jmtd
wants to merge
76
commits into
rh-openjdk:jlink-dev
Choose a base branch
from
jmtd:3591-merge-back-jlink
base: jlink-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzdata is deliberately broken in ubi-minimal images (presumably for disk space reasons). The fix is to reinstall the tzdata package: <https://access.redhat.com/solutions/5616681> This appears to add a neglibible amount to our image sizes (<1%) but resolves TZ issues for Java applications. <https://issues.redhat.com/browse/OPENJDK-2519> Signed-off-by: Jonathan Dowland <[email protected]>
Integrate the JLink workflow and scripts into the Ubi9 container sources
…tall [OPENJDK-2519] Add tzdata module to reinstall tzdata
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
https://issues.redhat.com/browse/OPENJDK-2595 Signed-off-by: Jonathan Dowland <[email protected]>
[OPENJDK-2595] fix docs labels for JDK21
[OPENJDK-2177] Move behave tests to relevant modules
…ule/jdk/ Signed-off-by: Jayashree Huttanagoudar <[email protected]>
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
[OPENJDK-2177]Create a dummy module.yaml to move openjdk.feature behave test to mod…
Document (as a comment) the issue of ordering pkg-update and tzdata modules. Depend upon the pkg-update module from tzdata, to ensure it runs first always. This has no effect on the container images as they stand now, since they have pkg-config occurring first already, but if that changed, this would catch it. Signed-off-by: Jonathan Dowland <[email protected]>
…er-dependency [OPENJDK-2519] tzdata module depend upon pkg-update
…urce repository https://github.com/jboss-container-images/openjdk-test-applications Signed-off-by: Jayashree Huttanagoudar <[email protected]>
[OPENJDK-2177] Delete OPENJDK-1549 as it is already moved to new test application source repository
Signed-off-by: Adriano Machado <[email protected]>
…riate modules Signed-off-by: Jayashree Huttanagoudar <[email protected]>
…them with appropriate modules Signed-off-by: Jayashree Huttanagoudar <[email protected]>
[OPENJDK-2177] Split the tests inside tests/features/java/runtime.feature to couple them with appropriate modules
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
[OPENJDK-2837] Follow-on test clean-up work for ubi9
Add a test which ensures s2i binary-build works with a destination directory not owned by UID 185 (/var/tmp), which means the running process does not have permission to change its timestamps, simulating a random UID and the permissions on /deployments. Signed-off-by: Jonathan Dowland <[email protected]>
If the S2I build runs as a user other than 185 (such as s2i's default of 1001), attempting to set the timestamp of /deployments will fail, causing the build to fail. https://issues.redhat.com/browse/OPENJDK-2850 See also https://issues.redhat.com/browse/OPENJDK-2408 Signed-off-by: Jonathan Dowland <[email protected]>
…nto run-java.sh - This tweak is to avoid defining JBOSS_CONTAINER_UTIL_LOGGING_MODULE as ENV in templates/jlink/Dokcerfile - Deleted run-env.sh and folded its content to run-java.sh as its not doing anything much other than setting value of JAVA_APP_DIR Signed-off-by: Jayashree Huttanagoudar <[email protected]>
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
…GING_MODULE and JBOSS_CONTAINER_JAVA_RUN_MODULE Signed-off-by: Jayashree Huttanagoudar <[email protected]>
Clean up run script
…sts. Instead checks for some common label and image labels are correct. So its good to rename the test. Signed-off-by: Jayashree Huttanagoudar <[email protected]>
[OPENJDK-2837] UBI9: Rename the test suitably
[OPENJDK-3351] Pin base image on :9.4 tag
Not JDK11 (EOL) Signed-off-by: Jonathan Dowland <[email protected]>
Bump version for next release
Update GitHub Pages URI to reflect new GitHub Organisation and repository names. <https://issues.redhat.com/browse/OPENJDK-3390> Signed-off-by: Jonathan Dowland <[email protected]>
[OPENJDK-3391] Update GitHub Pages URI
<https://issues.redhat.com/browse/OPENJDK-3410> Signed-off-by: Jonathan Dowland <[email protected]>
[OPENJDK-3410] update self-reference in GitHub pages for new URI
actions/upload-pages-artifact@v1 uses Artifact actions v3 which will be deprecated on 2024-12-05. Updating upload-pages-artifact to v3 requires updating deploy-pages to v4. Take the opportunity to update configure-pages@v5 as well. https://issues.redhat.com/browse/OPENJDK-3418 Signed-off-by: Jonathan Dowland <[email protected]>
[OPENJDK-3418] Bump GH Pages Actions to recent versions
In the redhat/* overrides files, override "from:" to use the name assigned to RHEL images built via OSBS from 9.5 onwards. https://issues.redhat.com/browse/OPENJDK-3430 Signed-off-by: Jonathan Dowland <[email protected]>
The repository has moved: update references. https://issues.redhat.com/browse/OPENJDK-3414 Signed-off-by: Jonathan Dowland <[email protected]>
…-test-applications [OPENJDK-3414] Update refs to openjdk-test-applications
…FROM [OPENJDK-3430] alter FROM line for redhat builds
Signed-off-by: Jonathan Dowland <[email protected]>
Bump JDK11 container versions
The changes in this fork are integrated upstream. https://issues.redhat.com/browse/OPENJDK-3450 Signed-off-by: Jonathan Dowland <[email protected]>
This test is designed to run a custom s2i/assemble script provided by the application source. That script prints the string "appsrc-provided s2i assemble script executed" during execution. Expand the test to check for this string to ensure the script has been executed. Signed-off-by: Jonathan Dowland <[email protected]>
[OPENJDK-3450] Stop using fork of behave-test-steps
[OPENJDK-3453] Ensure custom s2i script is run in test
The default path within images for S2I scripts is /usr/libexec/s2i. Some tools, in some circumstances, will try to execute scripts in that path. Create a symlink so they work. For RHEL10, we'll move the scripts to that location. https://issues.redhat.com/browse/OPENJDK-2805 Signed-off-by: Jonathan Dowland <[email protected]>
…path-ubi9 [OPENJDK-2805] Symlink /usr/libexec/s2i
Signed-off-by: Jonathan Dowland <[email protected]>
Update cekit/actions-setup-cekit to v1.1.7
This test seems to stall, especially for the runtime images. https://issues.redhat.com/browse/OPENJDK-3536 Signed-off-by: Jonathan Dowland <[email protected]>
…-test [OPENJDK-3536] temporarily disable flaky test
This test checks a custom test application source to ensure that a custom settings.xml, which defines a custom profile, has been activated. Signed-off-by: Jonathan Dowland <[email protected]>
…ile-active [OPENJDK-3597] test for MAVEN_SETTINGS_XML
The hsperfdata path is determined by the running user's username. This is no longer "jboss", but "default". Use "${USER}" so that we catch any future changes in username. Signed-off-by: Jonathan Dowland <[email protected]>
[OPENJDK-3637] clean up correct hsperfdata path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges ubi9 into jlink-dev and resolves the conflicts.
https://issues.redhat.com/browse/OPENJDK-3591