Update to 0.0.3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 372fb8d.
# Conflicts: # samples/messenger/feature_chat_impl/src/main/java/com/revolut/kompot/sample/feature/chat/ChatFeatureHandlerDelegate.kt # samples/messenger/feature_contacts_impl/src/main/java/com/revolut/kompot/sample/feature/contacts/ContactsFeatureHandlerDelegate.kt # samples/messenger/playground/src/main/java/com/revolut/kompot/sample/playground/PlaygroundFeatureHandlerDelegate.kt # samples/messenger/test_core/build.gradle # samples/messenger/test_core/src/main/AndroidManifest.xml # samples/messenger/test_core/src/main/java/com/revolut/kompot/sample/test/core/TestDispatcherExtension.kt
# Conflicts: # samples/messenger/app/src/main/java/com/revolut/kompot/sample/Features.kt # samples/messenger/app/src/main/java/com/revolut/kompot/sample/di/AppModule.kt # samples/messenger/app/src/main/java/com/revolut/kompot/sample/ui/flows/root/RootFlowImpl.kt # samples/messenger/app/src/main/java/com/revolut/kompot/sample/ui/flows/root/RootFlowModel.kt # samples/messenger/app/src/main/java/com/revolut/kompot/sample/ui/flows/root/di/RootFlowComponent.kt # samples/messenger/build.gradle # samples/messenger/feature_chat_impl/src/main/java/com/revolut/kompot/sample/feature/chat/ChatFeatureGateway.kt # samples/messenger/feature_contacts_impl/src/main/java/com/revolut/kompot/sample/feature/contacts/ContactsFeatureGateway.kt # samples/messenger/feature_contacts_impl/src/main/java/com/revolut/kompot/sample/feature/contacts/di/ContactsFeatureComponent.kt # samples/messenger/kompot_sample_dependencies.gradle # samples/messenger/kompot_test_core/src/main/java/com/revolut/kompot/sample/test/core/TestDispatcherExtension.kt # samples/messenger/playground/src/main/java/com/revolut/kompot/sample/playground/PlaygroundFeatureGateway.kt # samples/messenger/settings.gradle
funriser
requested review from
JuzTosS,
ivazhnov,
RKuanysh,
itshnegg and
aleksei-tvorogov
aleksei-tvorogov
previously approved these changes
Nov 15, 2023
views saved state scroller controllers prefetching minor fixes and improvements
RKuanysh
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewControlleras the new base class for all the screens and flows. The new API removes the necessity to subclass BaseScreen/BaseFlow to create a controller. Instead, you can plugin UI + Domain state management or flow logic to theViewControllerusing delegation instead of inheritance.ControllerModelExtensionholds reusable logic to delegate ControllerModel work and reuse it in the other models.ControllerDescriptorto resolve controller instances without injecting extra dependencies to the screen or flow.NavigationRequestto resolve navigation destinations asynchronously through theFeatureGateway.ViewController-based API brings support for the modals saved state restoration. Opening modals throughFlowCoordinatororModalCoordinatorwill make modals compatible with the saved state