Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert XML entities #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Convert XML entities #34

wants to merge 5 commits into from

Conversation

emg36
Copy link

@emg36 emg36 commented Oct 21, 2019

Replace potential XML valid symbols that intefer with rendering a pdf

Replace potential XML valid symbols that intefer with rendering a pdf
@suspectpart
Copy link

suspectpart commented Jun 10, 2021

I stumbled on the exact same problem, see #49.

Could we talk about having this as a feature and revise this solution? If we dropped Python 2 support (it's about time!), we could just use the html.escape standard lib function. Or, if Python 2 compatibility is still desired, run with the solution by @emg36 as it is exactly doing what html.escape is doing anyway.

@suspectpart
Copy link

@revolunet Are you still maintaining this library?

emg36 and others added 3 commits October 5, 2021 16:12
- use html escaping instead of .replace
- a conditional on the pdf data to skip keys with and underscore and/or have no key. This was to remove dictionaries that were being passed in, not just a key string value pair
merge in original project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants