Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for trivy fs #35

Merged
merged 9 commits into from
Sep 16, 2024
Merged

Add test for trivy fs #35

merged 9 commits into from
Sep 16, 2024

Conversation

nayuta
Copy link
Contributor

@nayuta nayuta commented Mar 15, 2024

Add test for trivy fs to check #17, the test was added.

Changes:

  • multiple test was supported with GitHub Actions' matrix
    • You can put the test under ./testdata directory with ./testdata/[trivy command]/[platform label]/[with_detections|without_detections]
    • e.g. current terraform test is in ./testdata/config/terraform/with_detections and ./testdata/config/terraform/without_detections

@haya14busa
Copy link
Member

Sorry for the late response. Can you resolve the conflicts?

@nayuta
Copy link
Contributor Author

nayuta commented Jun 11, 2024

Thanks. However, the test on Windows failed accidentally. So, I'll check it this weekend.

@haya14busa
Copy link
Member

I guess we can ignore the windows error for now. #51 (comment)

Is this review ready?

@nayuta
Copy link
Contributor Author

nayuta commented Jul 2, 2024

I guess we can ignore the windows error for now. #51 (comment)

Is this review ready?

Yes, it's ready.

@nayuta nayuta requested a review from haya14busa July 2, 2024 01:03
DIRS_RESULT="${DIRS_RESULT}${dir},"
fi
done
MATRIX_JSON=$(echo "${DIRS_RESULT}" | sed 's/,$//' | sed 's/\\n//g' | jq -R -s -c 'split(",") | [.[] | {dir: ., command: split("/")[2], type: split("/")[4], label: [split("/")[2],split("/")[3]] | join("/")}]')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments?
I don't quite understand what this script is doing.

@nayuta nayuta requested a review from haya14busa August 20, 2024 12:38
@nayuta
Copy link
Contributor Author

nayuta commented Sep 3, 2024

@haya14busa how do you think about this?

Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haya14busa haya14busa merged commit eec5058 into reviewdog:main Sep 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants