Skip to content

Commit

Permalink
build: turn on -fno-common to catch regressions
Browse files Browse the repository at this point in the history
Refs: libuv#2603
PR-URL: libuv#2604
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Jameson Nash <[email protected]>
  • Loading branch information
bnoordhuis authored and vtjnash committed Jan 10, 2020
1 parent d42a108 commit c7f99c7
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
'conditions': [
['OS != "zos"', {
'cflags': [ '-O0', '-fwrapv' ]
'cflags': [ '-O0', '-fno-common', '-fwrapv' ]
}],
['OS == "android"', {
'cflags': [ '-fPIE' ],
Expand Down Expand Up @@ -80,9 +80,10 @@
'conditions': [
['OS != "zos"', {
'cflags': [
'-fomit-frame-pointer',
'-fdata-sections',
'-ffunction-sections',
'-fno-common',
'-fomit-frame-pointer',
],
}],
]
Expand Down

0 comments on commit c7f99c7

Please sign in to comment.