Add token_info method, bump version #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrytrager
force-pushed
the
chore/tiktok-access-lost-DD-4674
branch
from
6bbff68 to
d491dea
Compare
AlphaB
reviewed
Dec 26, 2024
AlphaB
reviewed
Dec 26, 2024
lib/panda/client.rb
Outdated
| def get_token(path, params = {}) | ||
| request = Panda::HTTPRequest.new('GET', path, params) | ||
| response = Panda.make_get_request(request) | ||
| response.status == 200 ? response.parsed_body : nil |
There was a problem hiding this comment.
There is no need in checking status, error middleware will handle all non successful requests. Please add a separate structure that wraps raw response from TikTok like we do with collections
There was a problem hiding this comment.
Collection is a wrapper around enumerable with pagination. We don't have pagination here, I can just fetch data from response
There was a problem hiding this comment.
We wrap raw responses from API with our objects. Please, create a response object for this API and return it from this method
AlphaB
reviewed
Dec 26, 2024
dmitrytrager
force-pushed
the
chore/tiktok-access-lost-DD-4674
branch
2 times, most recently
from
6079de9 to
e19b92a
Compare
dmitrytrager
force-pushed
the
chore/tiktok-access-lost-DD-4674
branch
from
e19b92a to
3ca8cd2
Compare
AlphaB
reviewed
Dec 27, 2024
AlphaB
reviewed
Dec 27, 2024
dmitrytrager
force-pushed
the
chore/tiktok-access-lost-DD-4674
branch
from
6b6cb78 to
53f8b9e
Compare
AlphaB
reviewed
Dec 27, 2024
|
|
||
| module Panda | ||
| class TokenInfo | ||
| attr_reader :data |
There was a problem hiding this comment.
Looks like we don't use this reader anywhere
AlphaB
reviewed
Dec 27, 2024
lib/panda/client.rb
Outdated
| @@ -1,6 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'panda/collection' | |||
| require 'panda/token_info' | |||
There was a problem hiding this comment.
Let's keep imports sorted as they were
AlphaB
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.