fix(builtins): fix read builtin ignoring tab chars (#371)

Don't ignore whitespace chars, even if they're considered control characters.
reubeno · Feb 1, 2025 · d8a57de · d8a57de
1 parent ee71122
commit d8a57de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/brush-core/src/builtins/read.rs b/brush-core/src/builtins/read.rs
@@ -219,7 +219,7 @@ impl ReadCommand {
             }
 
             // Ignore other control characters without including them in the input.
-            if ch.is_ascii_control() {
+            if ch.is_ascii_control() && !ch.is_ascii_whitespace() {
                 continue;
             }
 

diff --git a/brush-shell/tests/cases/builtins/read.yaml b/brush-shell/tests/cases/builtins/read.yaml
@@ -36,3 +36,9 @@ cases:
       while IFS= read line; do
           echo "LINE: '$line'"
       done <<<"${content}"
+
+  - name: "read text with tabs and custom IFS"
+    stdin: |
+      while IFS="" read myvar; do
+          echo "myvar1: |${myvar}|"
+      done < <(printf "a\tb\nc d\te\n")