Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Cargo.toml, add Gemini example, refine error handling #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Cargo.toml, add Gemini example, refine error handling #6
Changes from all commits
4d6eae8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider removing redundant library settings.
The
test
anddoctest
settings are enabled by default for libraries. These explicit settings are unnecessary unless you have a specific reason to include them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider limiting tokio features in dev-dependencies.
Using
features = ["full"]
for tokio includes all features, which might be unnecessary for testing. Consider specifying only the features you need (e.g., "rt", "macros", "rt-multi-thread").📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider making the
Error
enum public if used across modules.Currently, the
Error
enum is private to this file. If you anticipate needing it elsewhere, addingpub
here can help maintain clarity and consistency across your project and keep your error types consolidated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider adding comments or docstrings.
GeminiResponseParser
is self-explanatory, but docstrings can clarify the reasoning and usage patterns.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Verify handling of chunked JSON.
Because the code handles
[
,]
, and partial data, confirm you never receive a chunk that splits a JSON object across boundaries. Otherwise,serde_json::from_str
will fail. If partial objects are possible, buffering logic might be necessary to reassemble JSON.Could you confirm how
GeminiClient
streams JSON to ensure each chunk is a complete object (or bracket) for this parser?