fix(skymp5-server): fix setDisplayName not cleared from db (skyrim-mu…

…ltiplayer#1920)
rethesda · Apr 14, 2024 · 58fa467 · 58fa467
1 parent 3f6de86
commit 58fa467
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/skymp5-server/cpp/server_guest_lib/MpObjectReference.cpp b/skymp5-server/cpp/server_guest_lib/MpObjectReference.cpp
@@ -29,6 +29,8 @@
 #include "OpenContainerMessage.h"
 #include "TeleportMessage.h"
 
+#include "script_classes/PapyrusObjectReference.h" // kOriginalNameExpression
+
 constexpr uint32_t kPlayerCharacterLevel = 1;
 
 UpdatePropertyMessage MpObjectReference::CreatePropertyMessage(
@@ -335,10 +337,12 @@ void MpObjectReference::VisitProperties(const PropertiesVisitor& visitor,
   }
 
   if (ChangeForm().displayName.has_value()) {
-    std::string raw = *ChangeForm().displayName;
-    nlohmann::json j = raw;
-    std::string displayNameAsJson = j.dump();
-    visitor("displayName", displayNameAsJson.data());
+    const std::string& raw = *ChangeForm().displayName;
+    if (raw != PapyrusObjectReference::kOriginalNameExpression) {
+      nlohmann::json j = raw;
+      std::string displayNameAsJson = j.dump();
+      visitor("displayName", displayNameAsJson.data());
+    }
   }
 
   // Property flags (isVisibleByOwner, isVisibleByNeighbor) should be checked

diff --git a/skymp5-server/cpp/server_guest_lib/script_classes/PapyrusObjectReference.cpp b/skymp5-server/cpp/server_guest_lib/script_classes/PapyrusObjectReference.cpp
@@ -857,11 +857,7 @@ VarValue PapyrusObjectReference::SetDisplayName(
     }
     const char* displayName = static_cast<const char*>(arguments[0]);
 
-    if (!strcmp(displayName, kOriginalNameExpression)) {
-      selfRefr->SetDisplayName(std::nullopt);
-    } else {
-      selfRefr->SetDisplayName(displayName);
-    }
+    selfRefr->SetDisplayName(displayName);
 
     bool force = static_cast<bool>(arguments[1]);
     std::ignore = force;