Improve from_fn and add com_ptr_from_fn macro #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestions I made for
from_fn
in the Rust Community Discord, with some further iterations. Namely:from_fn
returnsResult<ComPtr<T>, HRESULT>
instead ofResult<Option<ComPtr<T>>, E>
F
is redefined asFnOnce(&GUID, &mut *mut P) -> HRESULT
It also adds a
com_ptr_from_fn
function that generalizesfrom_fn
for COM functions that output multiple COM objects (such asICallFactory::CreateCall
).