Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update merge student bussiness logic into one file #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fatchul
Copy link

@fatchul fatchul commented Oct 13, 2021

Merged student domain into 1 service, because it will takes time to maintain if you separate per function per file. CMIIW

@restuwahyu13
Copy link
Owner

Thanks for your pull request @fatchul01, but if you're change services functionality, this app cannot be running, because these handlers I need services functionality, please check your pull request again. Thank you

@fatchul
Copy link
Author

fatchul commented Oct 13, 2021

updated, I think repository better not use plural naming, and why did you create many repositories instead of 1 repo, such as result and results

@restuwahyu13
Copy link
Owner

Please check handler method before renewing the service, why I'm making repository into a small part, because if the project gets bigger, it'll be easy maintenance, and the name all depends on what each one wants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants