Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header value null check #2241

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Header value null check #2241

merged 5 commits into from
Jul 11, 2024

Conversation

alexeyzimarev
Copy link
Member

Description

Ensure that when adding a header parameter with null value, it throws immediately, without waiting for request execution.
Allow multiple header values for one header key, also support properly adding header parameters with multiple values per header.

Fixes #2227
Fixes #2235

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

github-actions bot commented Jul 11, 2024

Test Results

   35 files     35 suites   19m 56s ⏱️
  438 tests   438 ✅ 0 💤 0 ❌
2 965 runs  2 965 ✅ 0 💤 0 ❌

Results for commit df05ab9.

♻️ This comment has been updated with latest results.

Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2024

Deploying restsharp with  Cloudflare Pages  Cloudflare Pages

Latest commit: df05ab9
Status: ✅  Deploy successful!
Preview URL: https://6c8d447f.restsharp.pages.dev
Branch Preview URL: https://header-null.restsharp.pages.dev

View logs

@alexeyzimarev alexeyzimarev merged commit 4ddda24 into dev Jul 11, 2024
11 checks passed
@repo-ranger repo-ranger bot deleted the header-null branch July 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant