Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out the default 'main' branch change #287

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

idorax
Copy link

@idorax idorax commented Feb 21, 2023

The fix of #279 was incomplete, which introduce a new failure that user has to specify the url like:

<fetch url="git://gerrit-git.engineering.redhat.com/kernel-tests?master#virt/beaker-core-task/install"/>

if the default branch of a repo is not 'main' but 'master'. Hence, let's back out the related change.

@idorax idorax marked this pull request as draft February 21, 2023 02:40
@idorax idorax force-pushed the dev.huanli.20230221.2701 branch from c356d87 to 6927cab Compare February 21, 2023 07:16
@idorax idorax changed the title Save the available branch for later reading Should not trust myopen() when detecting default branch Feb 21, 2023
The fix of PR 279 is incomplete, we'd like to discard the change of
the default 'main' branch. If user fetches 'main' branch, a workaround
by specifying the branch 'main' in the git query can be used. e.g.

<fetch url="git://FOO.redhat.com/kernel-tests?main#a/b/c"/>

Signed-off-by: Vector Li <[email protected]>
@idorax idorax force-pushed the dev.huanli.20230221.2701 branch from 6927cab to 3a4e0b4 Compare February 23, 2023 11:18
@idorax idorax changed the title Should not trust myopen() when detecting default branch Back out the default 'main' branch change Feb 23, 2023
@idorax idorax marked this pull request as ready for review February 23, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants