Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken side effects in embedded handlers api test #252

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Remove broken side effects in embedded handlers api test #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions services/node-services/src/embedded_handler_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,20 +101,16 @@ app.post("/consecutive_side_effects", async (req: Request, res: Response) => {

const result = await rs.invoke(id, {}, async (ctx: restate.RpcContext) => {
let invocationCount = 0;
const p1 = ctx.sideEffect<void>(async () => {
await ctx.sideEffect<void>(async () => {
invocationCount++;
});
const p2 = ctx.sideEffect<void>(async () => {
await ctx.sideEffect<void>(async () => {
invocationCount++;
});
const p3 = ctx.sideEffect<void>(async () => {
await ctx.sideEffect<void>(async () => {
invocationCount++;
});

await p1;
await p2;
await p3;

return { invocationCount };
});

Expand Down
Loading