Fix some gradle configuration #247
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,78 +73,83 @@ tasks { | |
| } | ||
| } | ||
|
|
||
| val testAlwaysSuspending by | ||
| registering(Test::class) { | ||
| environment = | ||
| environment + | ||
| baseRestateEnvironment(name) + | ||
| mapOf("RESTATE_WORKER__INVOKER__INACTIVITY_TIMEOUT" to "0s") | ||
|
|
||
| useJUnitPlatform { | ||
| // Run all the tests with always-suspending or only-always-suspending tag | ||
| includeTags("always-suspending | only-always-suspending") | ||
| } | ||
| // Increase a bit the default timeout | ||
| systemProperties["junit.jupiter.execution.timeout.testable.method.default"] = "30 s" | ||
| } | ||
|
|
||
| val testSingleThreadSinglePartition by | ||
| registering(Test::class) { | ||
| environment = | ||
| environment + | ||
| baseRestateEnvironment(name) + | ||
| mapOf( | ||
| "RESTATE_WORKER__PARTITIONS" to "1", | ||
| "RESTATE_TOKIO_RUNTIME__WORKER_THREADS" to "1", | ||
| "RESTATE_TOKIO_RUNTIME__MAX_BLOCKING_THREADS" to "1", | ||
| ) | ||
|
|
||
| useJUnitPlatform { | ||
| // Run all the tests with either no tags, or always-suspending tag | ||
| includeTags("none() | always-suspending") | ||
| } | ||
| // Increase a bit the default timeout | ||
| systemProperties["junit.jupiter.execution.timeout.testable.method.default"] = "30 s" | ||
| } | ||
|
|
||
| val testLazyState by | ||
| registering(Test::class) { | ||
| environment = | ||
| environment + | ||
| baseRestateEnvironment(name) + | ||
| mapOf( | ||
| "RESTATE_WORKER__INVOKER__DISABLE_EAGER_STATE" to "true", | ||
| ) | ||
|
|
||
| useJUnitPlatform { | ||
| // Run all the tests with either no tags, or always-suspending tag | ||
| includeTags("lazy-state") | ||
| } | ||
| } | ||
|
|
||
| val testPersistedTimers by | ||
| registering(Test::class) { | ||
| environment = | ||
| environment + | ||
| baseRestateEnvironment(name) + | ||
| mapOf("RESTATE_WORKER__TIMERS__NUM_TIMERS_IN_MEMORY_LIMIT" to "1") | ||
|
|
||
| useJUnitPlatform { | ||
| // Run all the tests with always-suspending or only-always-suspending tag | ||
| includeTags("timers") | ||
| } | ||
| // Increase a bit the default timeout | ||
| systemProperties["junit.jupiter.execution.timeout.testable.method.default"] = "20 s" | ||
| } | ||
|
|
||
| // Common configuration for all test tasks | ||
| withType<Test>().configureEach { | ||
| dependsOn(":services:http-server:jibDockerBuild") | ||
| dependsOn(":services:java-services:jibDockerBuild") | ||
| dependsOn(":services:node-services:dockerBuild") | ||
|
|
||
| maxParallelForks = 3 | ||
| } | ||
|
|
||
| check { | ||
| dependsOn(testAlwaysSuspending) | ||
| dependsOn(testSingleThreadSinglePartition) | ||
| dependsOn(testPersistedTimers) | ||
| dependsOn(testLazyState) | ||
| } | ||
|
Comment on lines
+149
to
+154
There was a problem hiding this comment. Nice, really cool. Now it is actually possible to run individually tests via There was a problem hiding this comment. I didn't notice that I fixed that as well 🤣 |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
toolchainthing fixes to a specific java version, which causes #237. Using source/target compatibility should work with any sdk version >= 17There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried now to enable the auto jvm download in the last commit, it sounds like a useful feature. I wonder though if it works on NixOS, perhaps @igalshilman give this a try to see if your machine likes it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like magic 🪄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that it works on my machine as well. Thanks @slinkydeveloper for working your magic on this ❤️