-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug when processing files with a single event #393
Conversation
Nice! I guess some pipelines are failing because it is not the same event that it is being evaluated? |
Still don't understand why some pipelines are failing, if you are checking a different event why only one observable has a different value e.g. on the TREX-DM validation pipeline? I would expect several observables failing... |
The observable that it is failing is For the ray-tracing case, all the values are changing, so I guess it is an issue affecting the seed by the fact that there is a different looping scheme? what do you think @nkx111 ? Merging the following PR should fix axion ray-tracer pipeline rest-for-physics/axionlib#55 |
Then this observable doesn't make much sense to me, in general we should have one observable per event, the rate can be computed later on... |
I looked into each timestamp of the first 10 events from the pipeline. It changes after this PR. I suspect that it is related somehow with the bug in TRestRawMultiFEMINOSToSignalProcess we already recorded. rest-for-physics/rawlib#36 Before the PR:
With this PR:
The assumed "correct behavior", considering the Anyway, despite the first few values of |
Yes, I think this is the case. Previously we are calling |
Yes, that might be a good choice. But does that mean that we need to move TRestEventRateAnalysisProcess to legacy? |
Ok, I think it is clear that it is harmless. I can update the file. @juanangp Thinking a bit more about, it is interesting to maintain the For example, in the case that at the raw stage we plug in the |
…single-event-file"" This reverts commit 4ca4959.
Issue #390.
The bug comes from when finished doing test run(before the actual event processing), REST will push-forward to the next event. Since there is only one event in the file, find the next non-existing event will actually trigger finish reading. Therefore the later processes will get null input event, and cause problems. This fix it to prevent push-forward of event entries during test run, if test run succeeds.