feat: update PHPStan lvl to 5 #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
feat/general/phpstan_4
branch
from
7dfe886 to
9ce7944
Compare
SMillerDev
changed the title
pprkut
requested changes
Mar 6, 2025
Comment on lines
+19
to
+43
| * @method string get(string $key) | ||
| * @method bool exists(string $key) | ||
| * @method array smembers(string $set) | ||
| * @method bool sismember(string $set, string $key) | ||
| * @method bool del(string $key) | ||
| * @method void set(string $key, mixed $value) | ||
| * @method bool expire(string $key, int $time) | ||
| * @method bool ping(?string $value = null) | ||
| * @method bool incrby(string $key, int $increment) | ||
| * @method bool decrby(string $key, int $decrement) | ||
| * @method bool rpush(string $key, string ...$element) | ||
| * @method array blpop(string|array $key, int $timeout) | ||
| * @method string|bool lpop(string $key, int $count = 1) | ||
| * @method string|bool rpop(string $key, int $count = 1) | ||
| * @method int rpoplpush(string $source, string $destination) | ||
| * @method int|false llen(string $key) | ||
| * @method array lrange(string $key, int $start, int $stop) | ||
| * @method void zadd(string $key, int $score, mixed ...$value) | ||
| * @method int zcard(string $key) | ||
| * @method int sadd(string $key, string $member) | ||
| * @method int srem(string $key, string $member) | ||
| * @method int lrem(string $key, int $count, string $element) | ||
| * @method array keys(string $pattern) | ||
| * @method int zrem(string $key, string|int ...$member) | ||
| * @method array zrangebyscore(string $key, int|string $min, int|string $max, array $options = []) |
There was a problem hiding this comment.
I have a list sourced from Credis that I put in #94. I think that one is slightly more accurate, considering Credis is the main supported driver
| @@ -97,7 +97,8 @@ public function isTracking() | |||
| /** | |||
| * Update the status indicator for the current job with a new status. | |||
| * | |||
| * @param int The status of the job (see constants in Resque\Job\Status) | |||
| * @param int $status The status of the job (see constants in Resque\Job\Status) | |||
| * @param int|null $result The result of the job | |||
There was a problem hiding this comment.
has to be mixed. $result can be pretty much anything returned from a Job's perform() method
Comment on lines
37
to
40
| /** | ||
| * @var object|\Resque\Job\JobInterface Instance of the class performing work for this job. | ||
| * @var object|\Resque\Job\JobInterface|null Instance of the class performing work for this job. | ||
| */ | ||
| private $instance; |
There was a problem hiding this comment.
This shouldn't be nullable. Where would the NULL come from?
| * @param string $prefix The prefix needs to be set for the status key | ||
| * @param string $queue The name of the queue to place the job in. | ||
| * @param class-string $class The name of the class that contains the code to execute the job. | ||
| * @param array|null $args Any optional arguments that should be passed when the job is executed. |
There was a problem hiding this comment.
Shouldn't be null. It should be an empty array for optional cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the PHPStan check to lvl 5. There are still some unresolved issues and the method types are based on the redis docs so might not be complete.