Suggest Chrome Extension Installation Popup #1318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
violetadev
reviewed
Oct 6, 2024
Comment on lines
+47
to
+56
| onClick={() => { | ||
| window.electron.ipcRenderer.sendMessage( | ||
| IPC_MAIN_CHANNELS.OPEN_EXTERNAL, | ||
| { | ||
| url: `https://chromewebstore.google.com/detail/responsively-helper/jhphiidjkooiaollfiknkokgodbaddcj`, | ||
| } | ||
| ); | ||
| window.electron.store.set('chromePopup.usesChrome', true); | ||
| onClose(); | ||
| }} |
There was a problem hiding this comment.
it is best practice to declare a new function outside of the onclick and then call it as in:
onClick={handleDownload}
If you declare a function inline in onClick={}, it will be recreated on every render. This can have performance implications
violetadev
reviewed
Oct 6, 2024
| url: `https://chromewebstore.google.com/detail/responsively-helper/jhphiidjkooiaollfiknkokgodbaddcj`, | ||
| } | ||
| ); | ||
| window.electron.store.set('chromePopup.usesChrome', true); |
There was a problem hiding this comment.
usesChrome is a bit vague, I would name this something like hasSeenChromeExtensionPopUp
violetadev
reviewed
Oct 6, 2024
| isTextButton | ||
| isPrimary | ||
| > | ||
| I do not use Chrome |
There was a problem hiding this comment.
I would change the text to "No, thank you", in order to cover more cases, like the person doesn't want it or they want to close the popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
resolves #1292
ℹ️ About the PR
A popup has been added to ask the user to install the "Responsively Helper" Chrome extension upon starting the Responsively App on desktop. The "Download Extension" button takes the user to the Chrome Web Store when clicked. The "I do not use Chrome" button marks the chromePopup.usesChrome variable false so that the popup will not appear again.
🖼️ Testing Scenarios / Screenshots
I tested using yarn to make sure the popup appears at the right time.