refactor: Allow integration tests to use source code #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests using jest's moduleNameMapper option
|
@faceyspacey you might find this addresses your concern about DX? LMK if there's anything else in the master branch that is not convenient for you dev workflow, obviously I'd like for it to be convenient for you. |
ScriptedAlchemy
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one remaining issue which I think will be fixed as soon as the PR here is released and we upgrade jest: jestjs/jest#7787
This removes the
src/in imports from the integration-tests package and makes the integration tests instead import the raw uncompiled source code. This means that its no longer necessary to build packages before the integration tests can test their latest versions.The trick was to use the moduleNamemapper: jestjs/jest#2702