fix(react-email): hot reloading with circular dependencies #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmfern
added
the
Package: react-email
🦋 Changeset detectedLatest commit: 38fa921 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant for #2304. The initial error there was the same as #1872, which has been fixed, but their reproduction also points out that circular dependencies end up reaching the maximum call stack size due to an infinite loop. The problem was specifically when trying to recursively resolve the dependents of a module, which would go on forever due to circular dependencies.
This pull request introduces a more stable way to, now iteratively, resolve dependents of a module without breaking with these use cases. It also refactors the tests we had for
createDependencyGraphto use a specific testing directory for this, which also now tests the use case of circular dependencies to avoid regression on this.