Skip to content

feat(create-email): remove the starter directory if it fails to get the versions #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabrielmfern
Copy link
Collaborator

@gabrielmfern gabrielmfern commented Jun 23, 2025

Before this pull request, if the user tried to run the starter, and if for some reason, the fetch of the versions failed, it would simply error and not remove the starter with broken versions. Now, it deletes the directory if the proper values of the versions fails to be set

@gabrielmfern gabrielmfern self-assigned this Jun 23, 2025
@gabrielmfern gabrielmfern added the Package: create-email Package for running `npx create-email` label Jun 23, 2025
Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: a33a3cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 4:39pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 4:39pm

Copy link

pkg-pr-new bot commented Jun 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/create-email@2310

commit: a33a3cb

@gabrielmfern gabrielmfern force-pushed the feat/remove-starter-if-fails-to-get-versions branch 2 times, most recently from 0b20038 to bcb349f Compare June 24, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: create-email Package for running `npx create-email`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant