Skip to content

Commit

Permalink
fix(dependencies): add invariant to dependencies, remove rimraf
Browse files Browse the repository at this point in the history
This fixes the dependencies and includes invariant as dependency and removes
rimraf from dependencies and adds it to dev-dependencies
Also fixes the eslint config to catch this kind of errors.
eslintignore contains invalid content
gitattributes is not necessary
  • Loading branch information
danez committed Sep 19, 2017
1 parent cc9a290 commit 92b3c87
Show file tree
Hide file tree
Showing 6 changed files with 172 additions and 176 deletions.
15 changes: 0 additions & 15 deletions .eslintignore

This file was deleted.

12 changes: 2 additions & 10 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
{
"extends": ["@researchgate/rg-base", "@researchgate/rg-react"],
"parser": "babel-eslint",
"rules": {
"import/no-extraneous-dependencies": [
"error",
{
"devDependencies": true
}
]
}
"extends": ["@researchgate/rg-react"],
"parser": "babel-eslint"
}
1 change: 0 additions & 1 deletion .gitattributes

This file was deleted.

10 changes: 10 additions & 0 deletions docs/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"rules": {
"import/no-extraneous-dependencies": [
"error",
{
"devDependencies": true
}
]
}
}
13 changes: 6 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@
"url": "https://github.com/researchgate/react-intersection-observer/issues"
},
"dependencies": {
"prop-types": "^15.5.10 || ^16.0.0",
"rimraf": "^2.6.1"
"invariant": "^2.2.2",
"prop-types": "^15.5.10"
},
"devDependencies": {
"@researchgate/babel-preset-rg": "^1.0.1",
"@researchgate/eslint-config-rg-base": "^0.3.0",
"@researchgate/eslint-config-rg-react": "^0.3.0",
"@storybook/addon-actions": "^3.2.0",
"@storybook/addon-options": "^3.2.4",
Expand All @@ -23,17 +22,17 @@
"cross-env": "^5.0.5",
"css-loader": "^0.28.4",
"eslint": "^4.6.1",
"eslint-plugin-prettier": "^2.3.1",
"husky": "^0.14.3",
"intersection-observer": "^0.4.2",
"invariant": "^2.2.2",
"jest": "^21.0.2",
"lint-staged": "^4.0.2",
"prettier": "^1.5.3",
"prop-types": "^15.5.10 || ^16.0.0",
"raw-loader": "^0.5.1",
"react": "^15.4.0 || ^16.0.0",
"react-dom": "^15.4.0 || ^16.0.0",
"react": "^15.4.0",
"react-dom": "^15.4.0",
"react-test-renderer": "^15.6.1",
"rimraf": "^2.6.1",
"standard-version": "^4.2.0",
"storybook-readme": "^3.0.6",
"style-loader": "^0.18.2",
Expand Down
Loading

0 comments on commit 92b3c87

Please sign in to comment.